Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cgit: fix config example #63752

Merged
merged 1 commit into from Jun 26, 2019
Merged

nixos/cgit: fix config example #63752

merged 1 commit into from Jun 26, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jun 25, 2019

Motivation for this change

The order of the keys matters: scan-path must be the last key for other settings to be taken into account.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The order of the keys matters: scan-path must be the last key for other settings
to be taken into account.
@bjornfor
Copy link
Contributor

Good point. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants