Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeciv_gtk: use gtk3 #63755

Closed
wants to merge 1 commit into from
Closed

freeciv_gtk: use gtk3 #63755

wants to merge 1 commit into from

Conversation

lightbulbjim
Copy link
Contributor

Motivation for this change

Switching from GTK2 to GTK3.

  • Improves the zoom handling on Linux/Wayland.
  • Fixes a segfault on MacOS.
  • Looks nicer (subjective).
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nbp June 25, 2019 01:12
@peterhoeg
Copy link
Member

#63760 adds the qt5 client as well as changes gtk2 -> gtk3 (and a few other things). Sorry about the duplication.

@lightbulbjim
Copy link
Contributor Author

Closing as a duplicate.

@lightbulbjim lightbulbjim deleted the freeciv-gtk3 branch June 25, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lightbulbjim @peterhoeg