Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] signal-desktop: 1.25.1 -> 1.25.3 (backport) #63828

Merged
merged 2 commits into from Jul 3, 2019
Merged

[19.03] signal-desktop: 1.25.1 -> 1.25.3 (backport) #63828

merged 2 commits into from Jul 3, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Jun 26, 2019

(cherry picked from commit 4ae9934)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
signal-desktop: 1.25.1 -> 1.25.2
ea37ce8 
(cherry picked from commit 4ae9934)
@primeos primeos added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 26, 2019
@primeos
Copy link
Member Author

primeos commented Jun 26, 2019

@GrahamcOfBorg test signal-desktop

@primeos
signal-desktop: 1.25.2 -> 1.25.3
66826cd 
(cherry picked from commit 1707911)
@primeos primeos changed the title [19.03] signal-desktop: 1.25.1 -> 1.25.2 (backport) [19.03] signal-desktop: 1.25.1 -> 1.25.3 (backport) Jul 3, 2019
@primeos
Copy link
Member Author

primeos commented Jul 3, 2019

@GrahamcOfBorg test signal-desktop

This should succeed now :)
1.25.2 was indeed affected by the blue screen bug on 19.03 (but not on nixos-unstable):
https://github.com/signalapp/Signal-Desktop/releases/tag/v1.25.3:

This release fixes an issue that prevented Signal Desktop from starting up for some users on Ubuntu 19.04 who felt slightly nostalgic about seeing a frozen blue screen for the first time in years.

@primeos primeos self-assigned this Jul 3, 2019
@primeos primeos merged commit 7d3f71c into NixOS:release-19.03 Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos