Skip to content

conda: Remove version suffix #63807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2019
Merged

conda: Remove version suffix #63807

merged 1 commit into from
Jun 30, 2019
+1 −1

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jun 26, 2019 •
edited
Loading

Currently the conda-shell binary is installed as
conda-shell-4.6.14 which is not very friendly to type.

With this change the binary is simply installed as conda-shell.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jluttine @bhipple

Sorry, something went wrong.

@adisbladis
conda: Remove version suffix

Verified

This commit was signed with the committer’s verified signature.
adisbladis
GPG key ID: 110BFAD44C6249B7
Verified
Learn about vigilant mode
ce22805 
Currently the `conda-shell` binary is installed as
`conda-shell-4.6.14` which is not very friendly to type.

With this change the binary is simply installed as `conda-shell`.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 26, 2019
@adisbladis adisbladis merged commit 5b09342 into NixOS:master Jun 30, 2019
@bhipple
Copy link
Contributor

bhipple commented Jun 30, 2019

Sorry for the slow review; had this in my inbox but was busy. Anyways, thanks for this change! This is much nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @bhipple