-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc: support running the testsuite. #63808
base: master
Are you sure you want to change the base?
Conversation
++ (optional (perl != null) perl); | ||
++ (optional (perl != null) perl) | ||
++ (optional (expect != null) expect) | ||
++ (optional (expect != null) dejagnu); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be dejagnu instead of expect. Maybe you could include them only when doCheck = true instead ? or add an assert to make sure expect/dejagnu are not null when doCheck is true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, copy & paste fail. I would prefer if it was gated on doCheck
, although I'm worried that if I just do that then afterwards use .override({...}: { doCheck = true; })
it won't add those dependencies after the fact (I'm not sure how lazy these fields are tbh).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as @teto suggested, add asserts and check against doCheck to append.
++ (optional (perl != null) perl); | ||
++ (optional (perl != null) perl) | ||
++ (optional (expect != null) expect) | ||
++ (optional (expect != null) dejagnu); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as @teto suggested, add asserts and check against doCheck to append.
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
Interesting! This still seems useful. |
Motivation for this change
I needed to submit a patch to GCC and they want confirmation of no regressions in the testsuite, and so I ended up using this expression with
nix-build
(parts specific to GCC trunk & my own patches omitted):Sadly, not all tests pass (it's unclear to me how many of those are broken upstream), so
doCheck = true
can't be turned on by default yet, but:expect
anddejagnu
dependencies are needed to run the test suite in the first placebuilder.sh
change allowscrt{1,i}.o
to be found for linking executable testsOverall, this did work well enough for me to be able to confirm the lack of regressions (by building GCC trunk and GCC trunk + my patch, and comparing the
.sum
files in the resulting build dirs).Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)