Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite JacobiSNCNDN #2221

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Rewrite JacobiSNCNDN #2221

merged 4 commits into from
Jun 25, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jun 24, 2019

No description provided.

pleroy added 3 commits June 24, 2019 22:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
double const five_k_over_2 = 2.5 * k;
double const three_k = 3.0 * k;
double const seven_k_over_2 = 3.5 * k;
double const four_k = 4.0 * k;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k/2, 3k/2, 5k/2, and 7k/2 are all used only once; inline them.

Consider trusting common subexpression elimination and inlining 2 * k, 3 * k, and 4 * k as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part done.

@eggrobin eggrobin added the LGTM label Jun 25, 2019
@pleroy pleroy merged commit 343571b into mockingbirdnest:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants