Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: 20190601_b -> 20190601_c #63743

Closed
wants to merge 1 commit into from
Closed

gildas: 20190601_b -> 20190601_c #63743

wants to merge 1 commit into from

Conversation

smaret
Copy link
Member

@smaret smaret commented Jun 24, 2019

Motivation for this change

Update gildas to the latest upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
Copy link
Member Author

smaret commented Jun 25, 2019

Gildas hangs on Darwin (see #63779), so it's better to put this PR on hold for the until this is fixed.

@smaret
Copy link
Member Author

smaret commented Jul 2, 2019

Closing this in favor of #64120

@smaret smaret closed this Jul 2, 2019
@smaret smaret deleted the gildas-201906c branch April 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q3k q3k q3k approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaret @q3k