-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openhab: init at 2.5.9 and NixOS module [WIP] #63814
base: master
Are you sure you want to change the base?
Conversation
2564efa
to
65aa89f
Compare
27c7610
to
17696f0
Compare
For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated
|
@GrahamcOfBorg eval |
type = types.package; | ||
example = literalExample '' | ||
pkgs.openhab.override { | ||
withAddons = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openhab
package doesn't appear to have a withAddons
attribute. Did it get removed, but this documentation hasn't been updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using this module with withAddons
- it's definitely there.
I don't know much when it comes to java or openhab, so this may be a problem with my config...
After reading your comment about missing crypto providers in openjdk, and seeing various references to openjdk not shipping with a JCE implementation, I was ready to write it off as unsupported with openjdk. However, I tried calling the same java function on its own, outside of openhab, and it appears to work:
As far as I can tell, they're both using the same openjdk8, but one of them can't find its crypto provider. |
df4b452
to
b6b7780
Compare
I marked this as stale due to inactivity. → More info |
2021 bump. Openhab 3 is out now, and I'd love to have that. |
2021 bump. Openhab 3 is out now, and I\'d love to have that.
So I have some good and some not-quite-so-good news about this.
I moved to OH3 some time ago and have a fully functioning module that handles both versions as well as package defs for both v2 and v3.
The not-quite-so-good news is that it's rather opinionated and made for *my* needs which means that the thought of
getting that properly upstreamed and subsequently having to rejig my own config based on the inevitable changes isn't
exactly a nice thought.
There is tons of value to getting all this upstream of course. I'm just wondering if we should push it in as-is for 21.05 but
tag it as "I know this is in a NixOS production release but it's likely to change".
|
I would personally be fine with just taking what you've built more or less as-is, and working towards making it more generic over time. Would it be possible to at least see what you have in a gist or something? |
I marked this as stale due to inactivity. → More info |
Bump |
I do apologize to everyone who's been waiting for this. I'm currently flakyfying this so people can get started on it. I've been using openHAB since way before this draft PR - it's great! |
@peterhoeg Ping. Do you happen to have your opinionated configuration publicly available somehow? I would volunteer to strip and streamline this to make it acceptable to nixpkgs. |
@peterhoeg ping. |
Yeah, so partial progress.
You can take a look here:
<https://gitlab.com/peterhoeg/openhab-flake>
But the module is a dump from much earlier that still hasn’t been cleaned up.
|
Hi, has anyone managed to get the module running? |
All, it’s in no way shape or form ready to go.
That being said, I’m planning on spending as much as possible of the hackday at the upcoming nixcon to get it ready for people to try out.
It works very well for my purposes here.
|
For everyone who is monitoring this, we managed to put a small team together at the hackday at nixcon to work on this and we now have the flake in a state where it can be used to bring up openhab with all the plumbing (but not much else) - most importantly there is no documentation/examples of any kind. I am aiming for a "developer release" with in the next few weeks at which point we will make a proper announcement, but you are all very welcome to drop by and have a look at https://github.com/peterhoeg/openhab-flake. On a site note - it's phenomenal to collaborate with others on something when you're sitting right next to each other. |
Motivation for this change
openHAB is a pretty nifty home-automation tool.
This is still very much a WIP.
Cc: @dotlambda might be interested
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)