Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.dde-control-center: init at 4.10.11 #63822

Merged
merged 2 commits into from Jun 28, 2019
Merged

deepin.dde-control-center: init at 4.10.11 #63822

merged 2 commits into from Jun 28, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Get #59023 going for 19.09 馃巻

I've left the redshift functionality unpatched because it looked too impure for NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

romildo
romildo requested changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the following hard coded paths should be fixed:

/usr/share/dde-control-center.conf ($out) in src/frame/widgets/utils.h
/usr/share/zoneinfo (tzdata) in src/frame/modules/datetime/timezone_dialog/timezone.cpp

@romildo
Copy link
Contributor

romildo commented Jun 27, 2019

It seems that deepin-sync-daemon is a private package that allows to synchronize configuration files to cloud networks. It exists in deepin linux, but not on arch linux.

@worldofpeace worldofpeace merged commit 8789ff3 into NixOS:master Jun 28, 2019
@worldofpeace worldofpeace deleted the dde-control-center/init branch June 28, 2019 02:15
@ofborg ofborg bot requested a review from romildo June 28, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @romildo