Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadowsocks-libev: fix shared libraries #63823

Merged
merged 1 commit into from Jun 27, 2019
Merged

shadowsocks-libev: fix shared libraries #63823

merged 1 commit into from Jun 27, 2019

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jun 26, 2019

Motivation for this change

Fix errors about shared libraries. Seems caused by #63185

ss-local: error while loading shared libraries: libipset.so: cannot open shared object file: No such file or directory
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 34693840 (33.09 MiB) -> 34882760 (33.27 MiB)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer requested a review from marsam June 26, 2019 19:40
@marsam marsam merged commit 0f7b8bd into NixOS:master Jun 27, 2019
@marsam
Copy link
Contributor

marsam commented Jun 27, 2019

Thanks a lot! I accidentally removed that line.

@oxalica oxalica deleted the fix/shadowsocks-libev_deps branch August 14, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxalica @marsam