nix.binaryCaches: always set https://cache.nixos.org #63810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many support questions when people add a new binary cache and they suddenly lose nixos substitutions. Most of the users want to keep that, so we're doing a breaking change. Previously to disable all binary caches one had to do: nix.binaryCache = []; Now the same is possible via: nix.binaryCache = lib.mkForce;
ofborg
bot
added
8.has: module (update)
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
aszlig
added a commit
to openlab-aux/vuizvui
that referenced
this pull request
Jun 26, 2019
Besides using the default value from options, I could have just used mkOptionDefault back then when I was writing this, but fortunately using the default attribute from the option itself now resulted in an eval error. Had I used mkOptionDefault, the value just would have been silently changed to the default value, since in NixOS/nixpkgs#63810 the default value now has priority 1000 instead of 1500 (mkOptionDefault). So since there is no longer an option default, we now can just set our binary cache in a singleton list (with priority 100) and be done. Signed-off-by: aszlig <aszlig@nix.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many support questions when people add a new binary cache
and they suddenly lose nixos substitutions.
Most of the users want to keep that, so we're doing a breaking change.
Previously to disable all binary caches one had to do:
Now the same is possible via:
TODO