Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner: 11.11.2 -> 12.0.2 #63771

Merged
merged 1 commit into from Jul 12, 2019
Merged

gitlab-runner: 11.11.2 -> 12.0.2 #63771

merged 1 commit into from Jul 12, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Jun 25, 2019

Motivation for this change

Update to latest version: https://gitlab.com/gitlab-org/gitlab-runner/blob/v12.0.0/CHANGELOG.md

The major version bump is not a significant change from the runners perspective.

The removed config options were not used in the nix module so there is no change to the service required.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp bachp requested a review from infinisil as a code owner June 25, 2019 13:14
jonringer
jonringer approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 63771 passed on NixOS
Diff LGTM

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/63771
1 package were build:
gitlab-runner

@bachp bachp changed the title gitlab-runner: 11.11.2 -> 12.0.0 gitlab-runner: 11.11.2 -> 12.0.1 Jun 26, 2019
@bachp
Copy link
Member Author

bachp commented Jun 26, 2019

12.0.1 was released with a fix for a submodule fetch issue

@bachp
Copy link
Member Author

bachp commented Jul 1, 2019

@infinisil ping

@bachp
Copy link
Member Author

bachp commented Jul 3, 2019

@fpletz can you merge this? I'm using it since almost a week without issue.

@max-wittig
Copy link
Contributor

@fpletz @infinisil What's the status here?

@bachp
gitlab-runner: 11.11.2 -> 12.0.2
e928aa6 
12.0.1 fixes an issue with git submodule fetching
12.0.2 fixes an issue with concurrent updated
@bachp bachp changed the title gitlab-runner: 11.11.2 -> 12.0.1 gitlab-runner: 11.11.2 -> 12.0.2 Jul 8, 2019
@bachp
Copy link
Member Author

bachp commented Jul 8, 2019

12.0.2 was released and includes a fix for a concurrent update issue: https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1447

@max-wittig
Copy link
Contributor

@flokli Can you help here?

@flokli
Copy link
Contributor

flokli commented Jul 12, 2019

Vacation-induced slackness, sorry for the delay ;-)

LGTM, merging.

@flokli flokli merged commit 3019a68 into NixOS:master Jul 12, 2019
@flokli
Copy link
Contributor

flokli commented Jul 12, 2019

Backported to 19.03 in d10e680.

@max-wittig
Copy link
Contributor

Thanks 👍

@bachp bachp deleted the gitlab-runner-12.0.0 branch July 12, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @max-wittig @flokli @jonringer