Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: allow overriding config of wrapped package #63783

Closed
wants to merge 1 commit into from
Closed

firefox: allow overriding config of wrapped package #63783

wants to merge 1 commit into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Jun 25, 2019

Motivation for this change

By moving the cfg variable into the wrapper arguments we are able to override it for an already wrapped package. For example, with this change one can have

pkgs.firefox-devedition-bin.override {
  cfg.enableBrowserpass = true;
}

which would otherwise be difficult to accomplish for packages having a complicated wrapped definition in all-packages.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rycee
firefox: allow overriding config of wrapped package
1dcb6db 
By moving the `cfg` variable into the wrapper arguments we are able to
override it for an already wrapped package. For example, with this
change one can have

    pkgs.firefox-devedition-bin.override {
      cfg.enableBrowserpass = true;
    }

which would otherwise be difficult to accomplish for packages having a
complicated wrapped definition in `all-packages.nix`.
@rycee
Copy link
Member Author

rycee commented Jul 8, 2019

Thanks for the reviews! Rebased to master in 06d8666.

@rycee rycee closed this Jul 8, 2019
@rycee rycee deleted the overridable-firefox-config branch July 17, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@teto teto teto approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rycee @fpletz @teto