Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.dm-sonnet: fix build #63806

Merged
merged 1 commit into from Jun 26, 2019
Merged

python.pkgs.dm-sonnet: fix build #63806

merged 1 commit into from Jun 26, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 26, 2019 •
edited

Motivation for this change

Fix a build failure cause by the recent bazel update in #63532.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner June 26, 2019 10:29
@timokau timokau changed the title python.pkgs.dm-sonnet: fix build, 1.30 -> 1.33 python.pkgs.dm-sonnet: fix build Jun 26, 2019
@timokau timokau closed this Jun 26, 2019
@timokau
Copy link
Member Author

timokau commented Jun 26, 2019

Github is pretty buggy recently. I didn't close anything. Can't reopen either.

@FRidh
Copy link
Member

FRidh commented Jun 26, 2019

Apparently there are no commits on this branch other than that is in master.

@timokau
Copy link
Member Author

timokau commented Jun 26, 2019

You're right, my fault. Did a wrong hard reset.

Do you have any idea why pip may fail to find a dependency even though its in propagatedBuildInputs? The dm-sonnet 1.33 build complains about a missing tensorflow-probability, apparently it didn't find any version:

Collecting tensorflow-probability>=0.6.0 (from dm-sonnet==1.33)
  ERROR: Could not find a version that satisfies the requirement tensorflow-probability>=0.6.0 (from dm-sonnet==1.33) (from versions: none)
ERROR: No matching distribution found for tensorflow-probability>=0.6.0 (from dm-sonnet==1.33)

@timokau timokau reopened this Jun 26, 2019
@timokau
Copy link
Member Author

timokau commented Jun 26, 2019

That was with commit 637c0ed, which I have since removed from this PR (since the fix has higher priority than the update and the update breaks).

@timokau timokau merged commit 6ee5152 into NixOS:master Jun 26, 2019
@timokau timokau deleted the dm-sonnet-fix branch June 26, 2019 11:58
@timokau timokau mentioned this pull request Jun 26, 2019
Merged
10 tasks
timokau added a commit to timokau/nixpkgs that referenced this pull request Jun 26, 2019
@timokau
python.pkgs.dm-sonnet: fix hash
5e042f2 
Follow up to NixOS#63806, where I failed
to update the hash.
@timokau timokau mentioned this pull request Jun 26, 2019
Merged
10 tasks
pull bot pushed a commit to avitex/nixpkgs that referenced this pull request Jun 26, 2019
@timokau
python.pkgs.dm-sonnet: fix hash (NixOS#63815)
54cbf55 
Follow up to NixOS#63806, where I failed
to update the hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @FRidh