Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5.12 base: Add patch to fix QTBUG-73459 #63775

Closed
wants to merge 1 commit into from
Closed

qt5.12 base: Add patch to fix QTBUG-73459 #63775

wants to merge 1 commit into from

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Jun 25, 2019

Motivation for this change

QT 5.12 introduced a regression, where a QT program wouldn't show its
tray icon, if there was no tray bar during program startup.

It got fixed already in Qt 5.12.4, but according to #57042 and its
sibling issues/PRs it doesn't seem to get fixed in near future for
nixpkgs.

The bug on the qt bugtracker: https://bugreports.qt.io/browse/QTBUG-73459

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bebehei
qt5.12 base: Add patch to fix QTBUG-73459
7b6d9fa 
QT 5.12 introduced a regression, where a QT program wouldn't show its
tray icon, if there was no tray bar during program startup.

It got fixed already in Qt 5.12.4, but according to NixOS#57042 and its
sibling issues/PRs it doesn't seem to get fixed in near future for
nixpkgs.
@bebehei bebehei requested a review from ttuegel as a code owner June 25, 2019 14:54
@ttuegel
Copy link
Member

ttuegel commented Jun 27, 2019

Is there a reason to backport this particular patch?

@bebehei
Copy link
Contributor Author

bebehei commented Jun 27, 2019

It's a super annoying bug. Other distros have backported it before release of 5.12.4 (see Arch) too.

I don't know yet the exact policies of NixOS backporting and I don't know, whether Qt 5.12.4 would get backported onto 19.03. But nevertheless after reading through the threads regarding the update of Qt 5.12, I guess it won't happen because of the required labor.

@ttuegel
Copy link
Member

ttuegel commented Jun 28, 2019

I don't know yet the exact policies of NixOS backporting and I don't know, whether Qt 5.12.4 would get backported onto 19.03. But nevertheless after reading through the threads regarding the update of Qt 5.12, I guess it won't happen because of the required labor.

I expect Qt 5.12.4 to be backported into NixOS 19.03, but I don't know when it will be in master so that it can be backported. So, I would support including this patch.

The workflow for this kind of change is: This change should go into staging (instead of release-19.03). Once it is merged, it should be backported to release-19.03 in a separate pull request using git cherry-pick -x. The changes to staging will eventually make it into master (it's also needed there for now). The rationale for this is that we would prefer that the release branch not diverge from master: the master branch has changes not in the release branch, but not vice versa.

@bkchr
Copy link
Contributor

bkchr commented Jul 10, 2019

I'm currently working on Qt 5.12.4, but something serious changed in the build system... I'm already debugging it to find the cause, but can still take some time.

@ttuegel
Copy link
Member

ttuegel commented Jul 10, 2019

@bkchr I'm about to open a pull request into staging with Qt 5.12.3 based on #60119, would that address some of the build system problems for you?

@bkchr
Copy link
Contributor

bkchr commented Jul 10, 2019

I'm not sure. I got a little bit further. Qtbase is compiling and some stuff building on it. Now I'm at qtwayland

@aanderse
Copy link
Member

@bkchr ping (status?)

@bkchr
Copy link
Contributor

bkchr commented Sep 1, 2019

@aanderse sorry, did not any time to look into it :(

@ghost ghost mentioned this pull request Sep 9, 2019
Merged
10 tasks
@bebehei
Copy link
Contributor Author

bebehei commented Sep 21, 2019

@petabyteboy Thank you for fixing this in all relevant branches!

@bebehei bebehei closed this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bebehei @ttuegel @bkchr @aanderse @FRidh