Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just: init at 0.4.0 #59306

Merged
merged 1 commit into from Apr 13, 2019
Merged

just: init at 0.4.0 #59306

merged 1 commit into from Apr 13, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 11, 2019

Motivation for this change

just is a handy way to save and run project-specific commands.

https://github.com/casey/just

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pSub
pSub requested changes Apr 11, 2019
View reviewed changes
pkgs/development/tools/just/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/just/default.nix Outdated Show resolved Hide resolved
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 11, 2019

@pSub Thanks for the review!
The test has been enabled.

@bobvanderlinden
Copy link
Member

Somehow this fails during the tests:

$ nix-build -A pkgs.just .
...

failures:

---- justfile::test::run_shebang stdout ----
thread 'justfile::test::run_shebang' panicked at 'expected a code run error, but got: error: Recipe `a` with shebang `#!/usr/bin/env sh` execution error: No such file or directory (os error 2)', src/justfile.rs:257:16
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.


failures:
    justfile::test::run_shebang

test result: FAILED. 91 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

@xrelkd xrelkd force-pushed the just branch 5 times, most recently from 55fc7e0 to 15889a4 Compare April 12, 2019 05:23
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 12, 2019

@bobvanderlinden Thanks for the review!
preCheck is updated. Please review it again, if possible.

@bobvanderlinden
Copy link
Member

Confirmed to be building and running correctly on NixOS.

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 13, 2019

@bobvanderlinden Thanks for the review!

@xrelkd xrelkd changed the title just: init at 0.3.13 just: init at 0.4.0 Apr 13, 2019
@pSub pSub merged commit 66dc6db into NixOS:master Apr 13, 2019
@xrelkd xrelkd deleted the just branch April 13, 2019 09:30
@xrelkd xrelkd mentioned this pull request Apr 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub requested changes

@bobvanderlinden bobvanderlinden bobvanderlinden approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @bobvanderlinden @pSub @GrahamcOfBorg