Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: 6.1.2 -> 6.1.3 #59307

Merged
merged 1 commit into from Apr 11, 2019
Merged

grafana: 6.1.2 -> 6.1.3 #59307

merged 1 commit into from Apr 11, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

Latest patch release with four bug fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (x86_64-linux & aarch64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test grafana

needs to be backported to 19.03 (ideally together with a9247d0)

tomberek
tomberek approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump. Tested on Ubuntu. Builds, runs as expected.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@xeji xeji merged commit a14e375 into NixOS:master Apr 11, 2019
xeji pushed a commit that referenced this pull request Apr 11, 2019
@WilliButz @xeji
grafana: 6.1.2 -> 6.1.3 (#59307)
d934d08 
(cherry picked from commit a14e375)
@xeji
Copy link
Contributor

xeji commented Apr 11, 2019

backported to 19.03 in 0d2e999 and d934d08

@WilliButz WilliButz deleted the grafana-update branch April 11, 2019 17:30
WilliButz added a commit to mayflower/nixpkgs that referenced this pull request Apr 11, 2019
@WilliButz
grafana: 6.1.2 -> 6.1.3 (NixOS#59307)
99ab261 
(cherry picked from commit a14e375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@WilliButz @nixos-discourse @xeji @tomberek @GrahamcOfBorg