Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Creating a cargo subsidy with a town as source was not considering min population. #7493

Merged
merged 1 commit into from Apr 11, 2019

Conversation

SamuXarick
Copy link
Contributor

SUBSIDY_CARGO_MIN_POPULATION was defined but not used anywhere. I suppose it was for this.

@PeterN
Copy link
Member

PeterN commented Apr 10, 2019

This was lost in 50e08f3 (r23408)

PeterN
PeterN previously requested changes Apr 10, 2019
Copy link
Member

@PeterN PeterN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This additional test can be moved up to just under the line where Town::GetRandom() is called. This will avoid needlessly testing and iterating cargo.

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 10, 2019
@PeterN PeterN merged commit 4ad981a into OpenTTD:master Apr 11, 2019
@SamuXarick SamuXarick deleted the SUBSIDY_CARGO_MIN_POPULATION branch April 11, 2019 21:56
PeterN pushed a commit to PeterN/OpenTTD that referenced this pull request May 2, 2019
LordAro pushed a commit that referenced this pull request May 28, 2019
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 28, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants