Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] gvfs: 1.38.1 -> 1.38.2 #59350

Merged
merged 1 commit into from Apr 12, 2019
Merged

[19.03] gvfs: 1.38.1 -> 1.38.2 #59350

merged 1 commit into from Apr 12, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Apr 12, 2019

Motivation for this change

fix https://nvd.nist.gov/vuln/detail/CVE-2019-3827

changelog: https://gitlab.gnome.org/GNOME/gvfs/blob/1.38.2/NEWS

closes #59161

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that everything still built.

@worldofpeace worldofpeace merged commit 43a797b into NixOS:release-19.03 Apr 12, 2019
@hedning hedning deleted the gvfs-bump branch October 15, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @worldofpeace @GrahamcOfBorg