Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/manual: update 17.03 -> 19.03 in upgrading section #59349

Merged
merged 1 commit into from Apr 12, 2019

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Apr 12, 2019

Motivation for this change

The manual references 17.03 in a few spots in the upgrading section of the manual. I think it makes sense to keep those references current as there are a lot of copy and paste warriors out there and it would be nice to make upgrading as easy as possible.

Things done

changed 17.03 -> 19.03 , and updated example to accurately cover this change as well

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Apr 12, 2019

In these docs is also a "release process" to do list. Could you add this task to that to-do list?

@mogorman
Copy link
Contributor Author

@grahamc made update to release process as well. great call.

@grahamc grahamc merged commit 628ba24 into NixOS:master Apr 12, 2019
@grahamc
Copy link
Member

grahamc commented Apr 12, 2019

Mind opening a backport PR? :) to 19.03

@mogorman mogorman deleted the manual-upgrading branch April 12, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants