Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.lektor: 2.3 -> 3.1.3 #59353

Merged
merged 3 commits into from Apr 14, 2019
Merged

pythonPackages.lektor: 2.3 -> 3.1.3 #59353

merged 3 commits into from Apr 14, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Apr 12, 2019 •
edited

Motivation for this change

Company is deploying a lektor based blog wanted to have the latest lektor version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner April 12, 2019 13:55
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.lektor python2Packages.pytest-pylint python2Packages.click python3Packages.lektor python3Packages.pytest-pylint python3Packages.click

@costrouc
Copy link
Member Author

Ready for merge.

@xeji xeji merged commit 61327db into NixOS:master Apr 14, 2019
@joachifm joachifm mentioned this pull request Apr 18, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix left review comments

@xeji xeji xeji left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@costrouc @lsix @xeji @GrahamcOfBorg @markuskowa