HTML: custom elements upgrade exception #16328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
hayatoito,
kojiishi,
rniwa,
snuggs and
TakayoshiKochi
|
Verified the tests by updating WebKit's implementation and running them. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Apr 15, 2019
And allow for simplification of "create an element" by moving a step into IDL. Tests: web-platform-tests/wpt#16328. Corresponding DOM changes: whatwg/dom#751. Fixes #4520.
annulen
pushed a commit
to qtwebkit/qtwebkit
that referenced
this pull request
Apr 18, 2019
…nt or tries to create itself https://bugs.webkit.org/show_bug.cgi?id=196892 Reviewed by Dean Jackson. LayoutTests/imported/w3c: Update the tests according to web-platform-tests/wpt#16328. * web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt: * web-platform-tests/custom-elements/upgrading/Node-cloneNode.html: * web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element-expected.txt: * web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html: Source/WebCore: Throw TypeError instead of InvalidStateError for consistency. This updates WebKit's custom elements implementation for whatwg/html#4525. Tests: imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html * bindings/js/JSCustomElementInterface.cpp: (WebCore::JSCustomElementInterface::upgradeElement): * bindings/js/JSHTMLElementCustom.cpp: (WebCore::constructJSHTMLElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@244293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
…nt or tries to create itself https://bugs.webkit.org/show_bug.cgi?id=196892 Reviewed by Dean Jackson. LayoutTests/imported/w3c: Update the tests according to web-platform-tests/wpt#16328. * web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt: * web-platform-tests/custom-elements/upgrading/Node-cloneNode.html: * web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element-expected.txt: * web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html: Source/WebCore: Throw TypeError instead of InvalidStateError for consistency. This updates WebKit's custom elements implementation for whatwg/html#4525. Tests: imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html * bindings/js/JSCustomElementInterface.cpp: (WebCore::JSCustomElementInterface::upgradeElement): * bindings/js/JSHTMLElementCustom.cpp: (WebCore::constructJSHTMLElement): Canonical link: https://commits.webkit.org/211194@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#4525.