Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-make: init at 0.17.1 #59302

Closed
wants to merge 1 commit into from
Closed

cargo-make: init at 0.17.1 #59302

wants to merge 1 commit into from

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 11, 2019

Motivation for this change

cargo-make is a Rust runner and build tool.

https://sagiegurari.github.io/cargo-make/
https://github.com/sagiegurari/cargo-make

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 11, 2019

@pSub Thanks for the review!
Some tests fail because they need network access.
However, Travis ensures a proper build.
See also: https://travis-ci.org/sagiegurari/cargo-make/builds/515874289

@pSub
Copy link
Member

pSub commented Apr 13, 2019

@GrahamcOfBorg build cargo-make

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 15, 2019

Hello @pSub, Thanks for the review.
I guess this can be merged now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants