Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: 1.14.6 -> 1.16.0 #59249

Closed
wants to merge 1 commit into from

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Apr 10, 2019

Motivation for this change

Version bump. this version in particular adds wireguard support which is terrific.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

This has already been bumped in staging 99d4472

However I'm seeing another path fixed in the patch

if (!nms_ibft_reader_load_blocks ("@openiscsi@/bin/iscsiadm", &blocks, &error)) {

Didn't read the source too see if it really needs to be fixed, but maybe it should.

@mogorman
Copy link
Contributor Author

ahh i didnt see it on master and just thought it wasnt there.

@worldofpeace
Copy link
Contributor

ahh i didnt see it on master and just thought it wasnt there.

Yep, that's because this causes a large amount of rebuilds. So it gets merged to staging.

@worldofpeace
Copy link
Contributor

Closing because we already have this update.

@mogorman mogorman deleted the network-manager branch April 23, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants