Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sqlparse: 0.2.4 -> 0.3.0 #59248

Closed
wants to merge 2 commits into from
Closed

pythonPackages.sqlparse: 0.2.4 -> 0.3.0 #59248

wants to merge 2 commits into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 10, 2019

Motivation for this change

Changelog: https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner April 10, 2019 04:11
@matthiasbeyer matthiasbeyer mentioned this pull request Apr 10, 2019
Closed
10 tasks
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.sqlparse python3.pkgs.sqlparse

dotlambda
dotlambda requested changes Apr 10, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks litecli, mycli, and pgcli. We need to wait until those release updates. See e.g. dbcli/pgcli#1033.

@marsam marsam force-pushed the update-pythonPackages.sqlparse branch from 0606941 to a39ba19 Compare May 31, 2019 05:43
@ofborg ofborg bot requested a review from dywedir May 31, 2019 06:03
@marsam
Copy link
Contributor Author

marsam commented Oct 6, 2019

addressed by #70257

@marsam marsam closed this Oct 6, 2019
@marsam marsam deleted the update-pythonPackages.sqlparse branch October 6, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @dotlambda @matthiasbeyer @GrahamcOfBorg