Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tk: use aqua backend on darwin #59240

Merged
merged 1 commit into from Apr 10, 2019
Merged

tk: use aqua backend on darwin #59240

merged 1 commit into from Apr 10, 2019

Conversation

matthewbauer
Copy link
Member

Most users don’t have xquartz, so let’s use the default window system
for macOS.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
tk: use aqua backend on darwin
82b8393 
Most users don’t have xquartz, so let’s use the default window system
for macOS.
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Apr 10, 2019
Ericson2314
Ericson2314 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo!!! Now I can actually teach git properly (gitk).

@endgame
Copy link
Contributor

endgame commented Apr 10, 2019

Successfully builds on my mac (Darwin 17.7.0, macOS 10.13.6), and I typed in a bit of a Tk sample app into wish, and it looked like it was working.

@Ericson2314 Ericson2314 merged commit 43cfb6e into NixOS:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @endgame @Ericson2314 @GrahamcOfBorg