Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demoit: init at unstable-2019-03-29 #56234

Merged
merged 2 commits into from Apr 10, 2019
Merged

demoit: init at unstable-2019-03-29 #56234

merged 2 commits into from Apr 10, 2019

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Feb 23, 2019

Motivation for this change

Add demoit application from dgageot
It lets include a shell in web pages (used in html5 slides (bespoke, reveal.js, ...))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy changed the title demoit: init at 391ed33 demoit: init at 20190211 Feb 27, 2019
pkgs/servers/demoit/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite git history as well.

pkgs/servers/demoit/default.nix Outdated Show resolved Hide resolved
pkgs/servers/demoit/default.nix Outdated Show resolved Hide resolved
pkgs/servers/demoit/default.nix Outdated Show resolved Hide resolved
pkgs/servers/demoit/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member

aanderse commented Apr 9, 2019

@freezeboy please rewrite the git history into 2 commits: the first to add yourself as a maintainer, and the second to be adding the package.

@aanderse
Copy link
Member

@GrahamcOfBorg build demoit

@aanderse aanderse changed the title demoit: init at 20190211 demoit: init at unstable-2019-03-29 Apr 10, 2019
@aanderse aanderse merged commit 29f5468 into NixOS:master Apr 10, 2019
@freezeboy freezeboy deleted the demoit branch July 10, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants