New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repology: fix homepage for a few packages - nothing else #59265
Conversation
@GrahamcOfBorg build puddletag krename anydesk broadlink-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"broadlink" -> "pythonPackages.broadlink"
nativeBuildInputs = [ extra-cmake-modules kdoctools wrapGAppsHook ]; | ||
|
||
propagatedBuildInputs = [ kconfig kcrash kinit kjsembed ]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other changes, eh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, "cleanup" might be a better commit message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not even that, there are new dependencies imported in krename
. I would split that out and explain why in the commit message.
For the "update homepage" parts of the patchset, I'd approve... but merging stuff with the wrong commit message is a no-no for me.
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not even that, there are new dependencies imported in krename. I would split that out and explain why in the commit message.
There aren't. The lines are just moved.
That's why @GrahamcOfBorg added the "10.rebuild-linux: 0" label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's actually true. Sorry about that!
Still, the commit message should be more explanatory about that ("Moved some attributed for better readability" would be fine for me, I guess).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving a few lines up before the meta tag doesn't change anything in terms of input (and hence output). But fair enough, I have amended the commit to mention the minor style changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not only homepage link fixes.
@dotlambda, good catch on the name - fixed. |
Motivation for this change
repology was showing a few errors for packages I maintain - think of it as spring cleaning.
No other changes.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)