Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpPackages.sqlsrv & phpPackages.pdo_sqlsrv: 5.6.0 -> 5.6.1 #59320

Merged
merged 1 commit into from Apr 13, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

Version bump.
Changelog: https://github.com/Microsoft/msphpsql/releases/tag/v5.6.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg build php71Packages.sqlsrv php72Packages.sqlsrv php73Packages.sqlsrv
@GrahamcOfBorg build php71Packages.pdo_sqlsrv php72Packages.pdo_sqlsrv php73Packages.pdo_sqlsrv

@aanderse
Copy link
Member Author

@GrahamcOfBorg build php71Packages.sqlsrv
@GrahamcOfBorg build php72Packages.sqlsrv
@GrahamcOfBorg build php73Packages.sqlsrv

@aanderse
Copy link
Member Author

@etu now that 19.03 is out how do you feel about a backport of this to 19.03?
@Ma27 how about you?

@Ma27
Copy link
Member

Ma27 commented Apr 12, 2019

As this is a only a patch release and seems to fix some issues, I guess that backporting should be fine 👍

@aanderse
Copy link
Member Author

As this is a only a patch release and seems to fix some issues, I guess that backporting should be fine +1

@Ma27 to clarify this package isn't in 19.03... I missed the freeze cutoff by mere hours. Now that 19.03 is out and no more feature freeze I'd like to get this package into 19.03.

@Ma27
Copy link
Member

Ma27 commented Apr 12, 2019

Ah I see. Backported of the package could've worked before the branchoff, however I'm not sure if we actually want to do this after the release.

@lheckemann thoughts?

@etu
Copy link
Contributor

etu commented Apr 12, 2019

@Ma27 Technically it was merged to master here #56379 in 18c70f9, which was done time-wise before the branchoff happened because the branch didn't exist yet when I merged it. But it still missed the window :(

But as I see it, it's up to @lheckemann to decide since he's release manager.

From my point of view, it's a new package, it cant break anything pre-existing.

But a freeze is a freeze, and a freeze should be respected because if you start making exceptions it easily leads to more exceptions.

@lheckemann
Copy link
Member

My suggested course of action would be to use these packages on 19.03 otherwise — perhaps by putting them into a NUR repository. The main reason I could imagine to backport it after all would be a long, expensive build, meaning that the cost of using it would be brought down significantly by having it in the official binary cache.

@etu
Copy link
Contributor

etu commented Apr 13, 2019

But I don't have any issues with merging this PR into master.

@etu etu merged commit 5f1b5fd into NixOS:master Apr 13, 2019
@aanderse aanderse deleted the php-sqlsrv branch April 13, 2019 09:53
@aanderse
Copy link
Member Author

Sorry for the hassle... but yes this will save an on site compile so thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants