New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpPackages.sqlsrv & phpPackages.pdo_sqlsrv: 5.6.0 -> 5.6.1 #59320
Conversation
@GrahamcOfBorg build php71Packages.sqlsrv php72Packages.sqlsrv php73Packages.sqlsrv |
@GrahamcOfBorg build php71Packages.sqlsrv |
As this is a only a patch release and seems to fix some issues, I guess that backporting should be fine 👍 |
@Ma27 to clarify this package isn't in 19.03... I missed the freeze cutoff by mere hours. Now that 19.03 is out and no more feature freeze I'd like to get this package into 19.03. |
Ah I see. Backported of the package could've worked before the branchoff, however I'm not sure if we actually want to do this after the release. @lheckemann thoughts? |
@Ma27 Technically it was merged to master here #56379 in 18c70f9, which was done time-wise before the branchoff happened because the branch didn't exist yet when I merged it. But it still missed the window :( But as I see it, it's up to @lheckemann to decide since he's release manager. From my point of view, it's a new package, it cant break anything pre-existing. But a freeze is a freeze, and a freeze should be respected because if you start making exceptions it easily leads to more exceptions. |
My suggested course of action would be to use these packages on 19.03 otherwise — perhaps by putting them into a NUR repository. The main reason I could imagine to backport it after all would be a long, expensive build, meaning that the cost of using it would be brought down significantly by having it in the official binary cache. |
But I don't have any issues with merging this PR into master. |
Sorry for the hassle... but yes this will save an on site compile so thank you very much. |
Motivation for this change
Version bump.
Changelog: https://github.com/Microsoft/msphpsql/releases/tag/v5.6.1
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)