Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compact UI #2132

Merged
merged 7 commits into from
Apr 12, 2019
Merged

More compact UI #2132

merged 7 commits into from
Apr 12, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Apr 11, 2019

No description provided.

string frame_warning = "";
if (!reference_frame_selector_.FrameParameters().Equals(
adapter_.plotting_frame_selector_.FrameParameters())) {
frame_warning = "Manœuvre frame differs from plotting frame";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should not be a warning (it was, but it should not be); people get confused and think this is bad, whereas it is the right thing to do in many circumstances.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@eggrobin eggrobin added the LGTM label Apr 12, 2019
@pleroy pleroy merged commit 3ab32db into mockingbirdnest:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants