Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.zeromq4-haskell_0_8_0: unbreak #59333

Closed

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Apr 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar
Copy link
Member Author

Tested with nix-build -A haskellPackages.zeromq4-haskell_0_8_0.

@xeji
Copy link
Contributor

xeji commented Apr 12, 2019

@GrahamcOfBorg build haskellPackages.zeromq4-haskell_0_8_0

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

@@ -250373,7 +250373,6 @@ self: {
description = "Bindings to ZeroMQ 4.x";
license = stdenv.lib.licenses.mit;
hydraPlatforms = stdenv.lib.platforms.none;
broken = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not edit this file! Note the comment at the very top.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, what file should I be editing instead? The comment at the top of the file doesn't have this information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first guess would be configuration-hackage2nix.yaml, but there doesn't seem to be an entry for zeromq4-haskell_0_8_0.

@peti peti closed this in 221f65b Apr 15, 2019
@vaibhavsagar vaibhavsagar deleted the unbreak-zeromq4-haskell_0_8_0 branch April 15, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants