Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocal: 2.3.0 -> 2.4.0 #59290

Merged
merged 2 commits into from Apr 11, 2019
Merged

vocal: 2.3.0 -> 2.4.0 #59290

merged 2 commits into from Apr 11, 2019

Conversation

jonafato
Copy link
Contributor

Motivation for this change

Vocal has a new release featuring a number of bug fixes and new features. See the full changelog at https://github.com/needle-and-thread/vocal/releases/tag/2.4.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Vocal has a new release featuring a number of bug fixes and new
features. See the full changelog at
https://github.com/needle-and-thread/vocal/releases/tag/2.4.0.
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a little cleanup there.

Things checked

  • built successfully
  • executed
  • added podcasts
  • played them

@worldofpeace worldofpeace merged commit a9489f4 into NixOS:master Apr 11, 2019
@jonafato jonafato deleted the vocal-2.4.0 branch April 11, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants