Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pytest-watch: init at 4.2.0 #59295

Closed
wants to merge 3 commits into from
Closed

python.pkgs.pytest-watch: init at 4.2.0 #59295

wants to merge 3 commits into from

Conversation

sveitser
Copy link
Contributor

Motivation for this change

Add pytest-watch.

Tested commands ptw and pytest-watch successfully with python2 and 3.7 on a small test project.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sveitser sveitser requested a review from FRidh as a code owner April 11, 2019 03:00
@adisbladis
Copy link
Member

adisbladis commented Apr 11, 2019 •
edited by grahamc

@GrahamcOfBorg eval

@dotlambda
Copy link
Member

Are you packaging this to use it for some other package you will submit later? In that case, it would be nice to put it all in a single PR.

dotlambda and others added 2 commits April 14, 2019 09:13
@dotlambda @sveitser
Apply suggestions from code review
e98d60e 
Co-Authored-By: sveitser <sveitser@gmail.com>
@sveitser
move pytest to buildInputs
632271c
@sveitser
Copy link
Contributor Author

Are you packaging this to use it for some other package you will submit later? In that case, it would be nice to put it all in a single PR.

No, I would just like to package pytest-watch.

@worldofpeace
Copy link
Contributor

This is now in nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis requested changes

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sveitser @adisbladis @dotlambda @worldofpeace @GrahamcOfBorg