[WIP] Add Elm 0.18 and update misc Haskell packages. #59335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Elm 0.18; - Update QuickCheck dependency for the Diff Haskell package, as Diff's tests break given an API change beginning with QuickCheck 2.12 (not working as expected, so I updated haskell-modules/configuration-common.nix to ignore Diff's tests; - Added contravariant dependency to aeson as this is required when compiling with GHC < 8.6.
dhruvio
changed the title
|
Putting this on hold, as I've run into haskell package dependency issues since |
|
No longer required, as Darwin fixes have been backported to nixos-18.03. Elm 0.18 works by pinning nixpkgs to commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge. Work in-progress.
Motivation for this change
Add Elm 0.18 (as
elm_0_18) to the package library. In the past, I used package pinning to use an old commit of this repo to install Elm 0.18. However, upgrading to macOS Mojave caused some regressions innixpkgs. While the necessary fixes were implemented recently innixpkgs, it is no longer possible to pin an older version ofnixpkgsto use Elm 0.18 on macOS Mojave.In addition, I ended up encountering several issues with Haskell modules during the build process. This PR includes those fixes as well:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)elm_0_18directory to avoid confusion and ensure this documentation didn't need to be maintained in two places.