ghc: apply fix to Haddock in relation to typechecker plugins #59317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update was generated by hackage2nix v2.14.2-5-g11c68fd from Hackage revision commercialhaskell/all-cabal-hashes@3d5bbe3.
This commit disables the library-for-ghci flag passed to `Setup configure` in the Haskell generic-builder.nix file. This stops the HSfoo.o file from being built. Building this HSfoo.o file caused doctest to take an extremely long time to load dependencies when running. This is a follow-up from NixOS#58743.
|
Merged in 2de3d6a. |
peti
pushed a commit
that referenced
this pull request
Apr 12, 2019
peti
pushed a commit
that referenced
this pull request
Apr 13, 2019
10 tasks
Taneb
pushed a commit
to Taneb/nixpkgs
that referenced
this pull request
Jun 11, 2019
Closes NixOS#59317. (cherry picked from commit a184604) Reason: this should be strictly a bug fix, to allow using Haddock and doctest with type-checker plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The version of Haddock bundled with GHC 8.6 fails with typechecker modules. This applies a patch which fixes that.
This is the main issue preventing me from moving away from nixpkgs 18.09 and GHC 8.4 at work.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)