New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: kernel: Add kernels with rt patchset #59268
Conversation
This patch adds kernels with the "realtime" patchset. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
I'm skeptical that we need/want all these kernel versions, do we? Also cc @NeQuissimus who does a lot of our (standard) kernel updates. |
I added them because the musnix project is using them. If we conclude to not add these, I'd be fine with that, we should (at least IMHO) somewhere add a note that
|
I have the same concern as @grahamc already for the kernel-ck but at the same time:
I think we should accept it and try to:
|
- eventually add localBuild if they are a problem for the cache ?
I think you mean `hydraPlatforms` here?
|
whatever prevents them from being added to the cache/overloading hydra. It might not be a concern though, just me overthinking it. |
This is essentially a patch on top of the regular releases, right? I'd be concerned if I can break these by updating the normal kernels. I would prefer this only be available for the current versions of LTS and latest (same as the hardened kernels). You can always override the derivation locally if you want a different version. |
@NeQuissimus Yes this can definitively be broken by updating the original kernels. That's why I would not even build this on hydra and only make it available in nixpkgs as an expression. If there's a possibility to opt out on hydra for these attributes. |
@matthiasbeyer Thanks for doing this. |
Check the testing kernel derivation, it opts out of hydra. |
@magnetophon I took their patches and started with them but then my patches evolved into what we have here. The idea to bring these kernels to nixpkgs was sparked because I saw their repository and thought it might be nice to have them. |
@matthiasbeyer Thanks. |
Apologies for the latency. I will review and provide opinion ASAP. |
In musnix, we apply the patch and special kernel configs to regular kernels. We may consider using these pre-patched kernels there at some point down the line. But for now, it's different enough that I'm afraid I don't have much to contribute here. |
Any updates on this? |
I tried to build this on the latest unstable, by putting
in my config. I get:
|
@magnetophon you need |
@matthiasbeyer Thanks, but I'm still getting the same error... |
Thank you for your contributions.
|
I am still using the musnix kernel. ad would love to have an rt kernel in NixOS. |
I'm going to add linux-rt (5.4 and 5.6) in #96702. It is based on the same kernel sources as the main kernel, is similar to packaging the main kernels, automatically enables PREEMPT_RT (which makes it equivalent to |
This patch adds kernels with the "realtime" patchset.
Motivation for this change
Having the realtime kernels in nixpkgs.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)I did not test-build this because this may take a rather long time on my machine and I want some feedback first.
As this was inspired by the musnix project, I ping them here:
@henrytill
@magnetophon
I imported the kernels into the
all-packages.nix
as an extra attribute to not spam the main namespace. I'm not sure whether this is wanted, but I guess people who do care find what they need and people who do not care are not bothered by that, right?