Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: fix steamrt trying to use a missing setup.sh #59326

Merged
merged 1 commit into from Apr 16, 2019
Merged

steam: fix steamrt trying to use a missing setup.sh #59326

merged 1 commit into from Apr 16, 2019

Conversation

puffnfresh
Copy link
Contributor

I was getting the following error after a Steam update:

internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@puffnfresh
steam: fix steamrt trying to use a missing setup.sh
964ef1b 
I was getting the following error after a Steam update:

    internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.
benley
benley approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@benley benley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same issue and this fixed it for me, thank you

@benley benley merged commit 098cf3b into NixOS:master Apr 16, 2019
@baracoder
Copy link
Contributor

Is it required to backport for 19.03?

@benley
Copy link
Member

benley commented Apr 16, 2019

Is it required to backport for 19.03?

I think so, yes. Totally forgot that the system where I encountered it was running 19.03.

@matthew-piziak
Copy link
Contributor

Is this part of https://github.com/NixOS/nixpkgs-channels/archive/nixos-unstable.tar.gz? I'm not sure if I'm reading this right: http://howoldis.herokuapp.com/

In any case I am still getting this error on that channel.

@benley
Copy link
Member

benley commented Apr 18, 2019

It looks like it hasn't made its way into nixos-unstable yet, but it does show up in the nixos-unstable-small channel if you want to try that one. Personally I just cherry-picked the commit onto a local checkout of nixos-unstable (from https://github.com/NixOS/nixpkgs-channels)

@matthew-piziak
Copy link
Contributor

Oh interesting. I think I know how to do that. If I fork nixpkgs-channels then I can make my own tarball to pull. Thank you @benley!

@benley
Copy link
Member

benley commented Apr 18, 2019

Also technically you don't need to make a tarball if you just want to use it locally. You can do something like nixos-rebuild -I nixpkgs=~/path/to/nixpkgs-channels and it will build using your working copy on disk.

@matthew-piziak
Copy link
Contributor

For the record nixpkgs-unstable-small works perfectly. Thanks!

And yeah, that's true but I'd rather have something hosted than I can share between machines; and something in my configuration.nix, since I like things specified in a version-controlled file, rather than ephemerally in a command line argument. Nevertheless thank you for the suggestion!

srhb pushed a commit to srhb/nixpkgs that referenced this pull request Apr 18, 2019
@puffnfresh @srhb
steam: fix steamrt trying to use a missing setup.sh (NixOS#59326)
595da06 
I was getting the following error after a Steam update:

    internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.

(cherry picked from commit 098cf3b)
@srhb srhb mentioned this pull request Apr 18, 2019
Merged
10 tasks
@jethrokuan jethrokuan mentioned this pull request Apr 18, 2019
Merged
10 tasks
@cpages cpages mentioned this pull request Apr 19, 2019
Closed
thomasjm pushed a commit to codedownio/nixpkgs that referenced this pull request Apr 24, 2019
@puffnfresh @thomasjm
steam: fix steamrt trying to use a missing setup.sh (NixOS#59326)
1f78451 
I was getting the following error after a Steam update:

    internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.

(cherry picked from commit 098cf3b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benley benley benley approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@puffnfresh @baracoder @benley @matthew-piziak @GrahamcOfBorg