Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quaternion-git: init at 0.0.9.4-rc3 #59256

Merged
merged 3 commits into from Apr 28, 2019
Merged

quaternion-git: init at 0.0.9.4-rc3 #59256

merged 3 commits into from Apr 28, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

The whole matrix ecosystem is evolving quite quickly, so we have to introduce both the 0.4 and 0.5 releases of libqmatrixclient in order to be able to try out the new quaternion versions.

The default library version stays at 0.4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build quaternion quaternion-git

@matthewbauer
Copy link
Member

I think it is usually best to keep just one version of an application at a time. We usually just want released software in Nixpkgs (although exceptions are possible)

@peterhoeg
Copy link
Member Author

We usually just want released software in Nixpkgs (although exceptions are possible)

In general I agree with you. But you do have some pieces of software that move so quickly that having multiple versions makes sense. This would be one of those (imho).

@peterhoeg peterhoeg changed the title quaternion-git: init at 0.0.9.4-rc2 quaternion-git: init at 0.0.9.4-rc3 Apr 24, 2019
@peterhoeg
Copy link
Member Author

@matthewbauer , do you have strong reservations about this particular -gitpackage? If not, I'll go ahead and merge this in a few days.

@peterhoeg peterhoeg merged commit 78bcc59 into NixOS:master Apr 28, 2019
@peterhoeg peterhoeg deleted the u/quaternion branch April 28, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @matthewbauer