Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37: get it to build again on darwin #59260

Merged
merged 1 commit into from Apr 10, 2019
Merged

python37: get it to build again on darwin #59260

merged 1 commit into from Apr 10, 2019

Conversation

domenkozar
Copy link
Member

Address #56826 (comment) with a workaround.

@domenkozar domenkozar requested a review from FRidh as a code owner April 10, 2019 10:21
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Apr 10, 2019
@domenkozar
Copy link
Member Author

@GrahamcOfBorg build python3

domenkozar referenced this pull request Apr 10, 2019
@FRidh
python3: 3.7.2 -> 3.7.3
0ddae82
@domenkozar
Copy link
Member Author

  • noop on linux/aarch
  • fixes python build on darwin

@domenkozar domenkozar merged commit 70cff41 into NixOS:release-19.03 Apr 10, 2019
@jhenahan
Copy link
Contributor

I have an ugly patch in my personal config that lets the existing patch apply cleanly by stripping out the AIX logic that got added in 3.7.3.

https://gist.github.com/jhenahan/da79b184bbe8cfbc330d88a671f04848

@strager
Copy link
Contributor

strager commented Apr 20, 2019

Commit fdbcf5b (on master) includes an updated distutils patch. Should we backport that commit (and maybe commit 0bf2d63 too) to release-19.03?

@LnL7
Copy link
Member

LnL7 commented Apr 20, 2019

Did I not backport it?

@strager
Copy link
Contributor

strager commented Apr 21, 2019

@LnL7, my bad, it has been backported into release-19.03!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@domenkozar @jhenahan @strager @LnL7 @GrahamcOfBorg