Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge simple updates #59259

Closed
wants to merge 6 commits into from
Closed

Merge simple updates #59259

wants to merge 6 commits into from

Conversation

matthiasbeyer
Copy link
Contributor

Merges multiple PRs into one. I reviewed all of them. All of them are simple updates (as in "hash and sha update", modulo one "doCheck = false" removal).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

I don't see the point in combining unrelated updates from existing PRs.
It's easier to review and merge the original PRs one by one.

@matthiasbeyer matthiasbeyer deleted the merge-simple-updates branch April 10, 2019 09:42
@timokau
Copy link
Member

timokau commented Apr 10, 2019

@matthiasbeyer maybe you'd be interested in https://discourse.nixos.org/t/prs-already-reviewed/2617 :)

xrelkd and others added 6 commits April 10, 2019 12:20
@xrelkd @matthiasbeyer
ethabi: 4.1.0 -> 7.0.0
ab15dc0 
(cherry picked from commit 6e42e2e)
@xrelkd @matthiasbeyer
go-ethereum: 1.8.22 -> 1.8.25
f1fe90d 
(cherry picked from commit de42f6e)
@NathanielHill @matthiasbeyer
now-cli: 14.0.3 -> 15.0.3
dccf78e 
(cherry picked from commit 86986ac)
@dnaq @matthiasbeyer
libsodium: 1.0.16 -> 1.0.17
94ddd61 
(cherry picked from commit 7303aad)
@aanderse @matthiasbeyer
flightgear: 2018.2.2 -> 2018.3.1
f2bbdf6 
(cherry picked from commit 56219a5)
@marsam @matthiasbeyer
pythonPackages.sqlparse: 0.2.4 -> 0.3.0
6aea525 
(cherry picked from commit 0606941fa5f988a9423e779b6201eefcf1be5fa8)
@markuskowa
Copy link
Member

@matthiasbeyer See also https://nixos.org/nixpkgs/manual/#sec-reviewing-contributions
The title of this PR is misleading since at least one update (#59233) has 501+ rebuilds and some trouble with a build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@matthiasbeyer @xeji @timokau @markuskowa @GrahamcOfBorg @xrelkd @NathanielHill @dnaq @aanderse @marsam