Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boringtun: init at 20190407 #59345

Merged
merged 1 commit into from Apr 13, 2019
Merged

boringtun: init at 20190407 #59345

merged 1 commit into from Apr 13, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 12, 2019

Motivation for this change

BoringTun is an implementation of the WireGuard® protocol designed for portability and speed.
https://github.com/cloudflare/boringtun

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

markuskowa
markuskowa requested changes Apr 12, 2019
View reviewed changes
pkgs/tools/networking/boringtun/default.nix Outdated

rustPlatform.buildRustPackage rec {
pname = "boringtun";
version = "0.2.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Github page does not show any release yet and states that the software is still under security review. I would suggest to use 20190407 as version number to indicate that it is an unstable version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
Let's use 20190407 as version number to indicate that it is an unstable version.

@markuskowa
Copy link
Member

markuskowa commented Apr 12, 2019 •
edited

@GrahamcOfBorg build boringtun

@xrelkd xrelkd changed the title boringtun: init at 0.2.0 boringtun: init at 20180407 Apr 13, 2019
@xrelkd xrelkd changed the title boringtun: init at 20180407 boringtun: init at 20190407 Apr 13, 2019
@markuskowa markuskowa merged commit 32ef10d into NixOS:master Apr 13, 2019
@xrelkd xrelkd deleted the boringtun branch April 13, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @markuskowa @GrahamcOfBorg