mkchromecast: init at 5872a246 #59280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvanderlinden
force-pushed
the
pr-init-mkchromecast
branch
from
4549dc3
to
ffa9317
Compare
FRidh
requested changes
Apr 11, 2019
| pulseaudio vorbis-tools sox lame flac faac ffmpeg | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.
| @@ -0,0 +1,27 @@ | |||
| { lib, fetchFromGitHub, buildPythonApplication, pulseaudio | |||
There was a problem hiding this comment.
use python3Packages as argument instead
etu
reviewed
Apr 11, 2019
| , vorbis-tools, sox, lame, flac, faac, ffmpeg }: | ||
| buildPythonApplication rec { | ||
| pname = "mkchromecast"; | ||
| version = "5872a246f0610b74fc2b197eb02dc91b96fb68cc"; |
There was a problem hiding this comment.
Should be something human readable, like "unstable-2011-12-31" (change the date to the commit date of course)
|
Sorry for the duplicate. This was apparently already submitted and the PR is in a further stage than this one: #57033 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds the mkchromecast package. i have tested this using:
And it would show my screen on my TV after a few moments.
The upgrade of pychromecast was not needed strictly speaking, but it seemed appropriate to enable all functionality of mkchromecast.
There wasn't a recent release, but that's something that hopefully will come (muammar/mkchromecast#244).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)