Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nixpkgs-pytools: init at 1.0.0 #59279

Merged
merged 1 commit into from Apr 11, 2019
Merged

python3Packages.nixpkgs-pytools: init at 1.0.0 #59279

merged 1 commit into from Apr 11, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

nixpkgs-pytools has been added to the nix-community! https://github.com/nix-community/nixpkgs-pytools

Adding a release to nixpkgs to make it easier to use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @makefu

@costrouc costrouc requested a review from FRidh as a code owner April 10, 2019 21:29
@costrouc costrouc force-pushed the python-nixpkgs-pytools-init branch from a6d4c56 to 4bd4279 Compare April 10, 2019 21:31
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.nixpkgs-pytools

@costrouc costrouc mentioned this pull request Apr 10, 2019
Closed
makefu
makefu suggested changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add python3.pkgs.nixpkgs-pytools to top-level/default.nix as well as this is more a cli tool than a python library.

Running $(nix-build -A python3.pkgs.nixpkgs-pytools)/bin/python-package-init nixpkgs-pytools --version 1.0.0 results in https://gist.github.com/makefu/91f34bbf91c7cc9a52b47a8eb87cb294 which is damn close to this PR (a good thing!)

Changelog can be found at https://github.com/nix-community/nixpkgs-pytools/blob/master/CHANGELOG.md

@costrouc
Copy link
Member Author

Thanks for adding a changelog I will make sure to use that. Also will add to top-level to make it a cli tool as well.

@costrouc costrouc force-pushed the python-nixpkgs-pytools-init branch from 4bd4279 to ad18ee9 Compare April 11, 2019 12:36
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.nixpkgs-pytools

@makefu
Copy link
Contributor

makefu commented Apr 11, 2019

@GrahamcOfBorg build nixpkgs-pytools

makefu
makefu approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dotlambda
dotlambda approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Thanks a lot for writing this helpful script @costrouc!

@dotlambda dotlambda merged commit d27643b into NixOS:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @makefu @dotlambda @GrahamcOfBorg