Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afl-qemu: remove unnecessary build dependencies #59286

Merged
merged 2 commits into from Apr 12, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 10, 2019

Motivation for this change

This simply removes all the unnecessary build dependencies for the afl-patched qemu. It looks like it was initially a copy of the regular qemu package, but afl only uses qemu in a very minimal manner (e.g. it doesn't even use system mode). So I trimmed this down to what seems to be the bare minimum with a process of trial and error.

Also added myself to the maintainers list for afl as I've tinkered with this package quite a bit now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle changed the title Ris afl qemu diet afl-qemu: remove unnecessary build dependencies Apr 10, 2019
@veprbl
Copy link
Member

veprbl commented Apr 10, 2019

cc @risicle

@veprbl
Copy link
Member

veprbl commented Apr 11, 2019

@GrahamcOfBorg build afl

@joachifm joachifm merged commit 1b49e1a into NixOS:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants