Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buck: 2017.10.01.01 -> 2019.01.10.01 #59340

Merged
merged 1 commit into from Apr 12, 2019
Merged

buck: 2017.10.01.01 -> 2019.01.10.01 #59340

merged 1 commit into from Apr 12, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 12, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 12, 2019

I'm not familiar with buck but the documentation mentions a daemon program buckd, which was present in the old version but is not generated any more with this PR. Has buckd been removed?

@marsam
Copy link
Contributor Author

marsam commented Apr 12, 2019

I'm not familiar with buck but the documentation mentions a daemon program buckd

the daemon buckd is started the first time buck is executed

[...] Has buckd been removed?

yes, it was removed facebook/buck@dd7ecf2, also if you download their binary releases, it does not ship buckd anymore.

@xeji xeji merged commit 6ebcac7 into NixOS:master Apr 12, 2019
@marsam marsam deleted the update-buck branch April 12, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants