Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "spotify: 1.0.96.181.gf6bc1b6b-12 -> 1.1.0.237.g378f6f25-11" #59269

Merged
merged 1 commit into from Apr 10, 2019
Merged

Revert "spotify: 1.0.96.181.gf6bc1b6b-12 -> 1.1.0.237.g378f6f25-11" #59269

merged 1 commit into from Apr 10, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Apr 10, 2019 •
edited

This reverts commit ea87db2.

See #57800

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from NeQuissimus April 10, 2019 15:00
matthiasbeyer
matthiasbeyer approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the diff, this looks good to me. Cannot test though.

@Ma27
Copy link
Member

Ma27 commented Apr 10, 2019

Currently testing/building locally...

@Ma27 Ma27 merged commit 52ff529 into NixOS:master Apr 10, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 10, 2019

@srhb thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@edolstra edolstra Awaiting requested review from edolstra

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @Ma27 @matthiasbeyer @GrahamcOfBorg