Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-generic-builder: backport disable-library-for-ghci #59303

Merged
merged 1 commit into from Apr 12, 2019
Merged

haskell-generic-builder: backport disable-library-for-ghci #59303

merged 1 commit into from Apr 12, 2019

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Apr 11, 2019 •
edited

This is a backport of #59297 to 19.03.

Motivation for this change

This PR causes quite a few rebuilds of Haskell packages, but it should arguably be backported to 19.03 since it is apparently working around a GHC bug (https://gitlab.haskell.org/ghc/ghc/issues/15524) as reported by @michaelpj here.

At work we are following the release-19.03 branch, so it would be helpful for us if this PR got in 19.03 to work around the long build-times caused by this bug.

(cherry picked from commit 0698b54)

Pinging @peti.

I guess I should also ping the release manager for 19.03, but I don't remember who it is. Maybe @lheckemann or the @NixOS/backports team?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
haskell-generic-builder: disable library-for-ghci by default
353e200 
This commit disables the library-for-ghci flag passed to
`Setup configure` in the Haskell generic-builder.nix file.

This stops the HSfoo.o file from being built.  Building this
HSfoo.o file caused doctest to take an extremely long time
to load dependencies when running.

This is a follow-up from NixOS#58743.

(cherry picked from commit 0698b54)
peti
peti requested changes Apr 12, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge yet! The underlying patch hasn't been accepted to master yet. We're still testing this change in haskell-updates.

@cdepillabout cdepillabout changed the title haskell-generic-builder: backport disable-library-for-ghci [WIP] haskell-generic-builder: backport disable-library-for-ghci Apr 12, 2019
@cdepillabout
Copy link
Member Author

@peti, sorry, I've added [WIP] to the title.

@peti peti changed the title [WIP] haskell-generic-builder: backport disable-library-for-ghci haskell-generic-builder: backport disable-library-for-ghci Apr 12, 2019
@peti peti merged commit 10c1a41 into NixOS:release-19.03 Apr 12, 2019
@cdepillabout cdepillabout deleted the disable-library-for-ghci-19.03 branch April 12, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdepillabout @peti @GrahamcOfBorg