Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nixpkgs: 0.2.2 -> 0.2.3 #59304

Merged
merged 1 commit into from Apr 11, 2019
Merged

python3Packages.nixpkgs: 0.2.2 -> 0.2.3 #59304

merged 1 commit into from Apr 11, 2019

Conversation

t184256
Copy link
Contributor

@t184256 t184256 commented Apr 11, 2019

Motivation for this change

I've upstreamed a patch for nixpkgs-python-importer by @adisbladis that dealt with pythonix renaming NixRef to NixError.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@t184256 t184256 requested a review from FRidh as a code owner April 11, 2019 09:37
@FRidh FRidh merged commit 5d81445 into NixOS:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t184256 @FRidh @GrahamcOfBorg