Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan-tools: add dependency on vulkan-headers #59322

Merged
merged 1 commit into from Apr 12, 2019

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Apr 11, 2019

This fixes the build on NixOS.

Motivation for this change

The vulkan-tools package did not build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This fixes the build on NixOS.
@infinisil
Copy link
Member

@GrahamcOfBorg build vulkan-tools

I suggested the removal of vulkan-headers from vulkan-loader in #55959 (comment)

I think it's still alright, we'll just fix breakages as they come.

Ping @Ralith

@infinisil infinisil merged commit cacb6f1 into NixOS:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants