Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepassxc: 2.3.4 -> 2.4.0 #59296

Merged
merged 3 commits into from Apr 11, 2019
Merged

keepassxc: 2.3.4 -> 2.4.0 #59296

merged 3 commits into from Apr 11, 2019

Conversation

Quiark
Copy link
Contributor

@Quiark Quiark commented Apr 11, 2019 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Quiark
WIP: keepassxc: 2.3.4 -> 2.4.0
44225eb 
running test doesn't work currently because of finding qt plugins
@Quiark Quiark changed the title WIP: keepassxc: 2.3.4 -> 2.4.0 keepassxc: 2.3.4 -> 2.4.0 Apr 11, 2019
@Quiark
Copy link
Contributor Author

Quiark commented Apr 11, 2019

wait with merge - this build can't open my database

bobvanderlinden
bobvanderlinden suggested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@bobvanderlinden bobvanderlinden left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build correctly on NixOS and worked on my database once I made the suggested change.

pkgs/applications/misc/keepassx/community.nix Outdated Show resolved Hide resolved
@Quiark
Copy link
Contributor Author

Quiark commented Apr 11, 2019

official 2.4.0 download from keepassxc website also cannot open my database
a new database (created with 2.3.4 without keyfile) can be opened in this build

so apparently not a packaging bug

@bobvanderlinden @Quiark
keepassxc: run test with offscreen qt plugin
77ce909 
Co-Authored-By: Quiark <me@rplasil.name>
dotlambda
dotlambda approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can open a database from a few years ago without a problem.

@pSub pSub merged commit eeec334 into NixOS:master Apr 11, 2019
@dotlambda
Copy link
Member

@pSub Why did you merge even though @Quiark has reported problems with the new version?

@bobvanderlinden bobvanderlinden mentioned this pull request Apr 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@bobvanderlinden bobvanderlinden bobvanderlinden requested changes

@dotlambda dotlambda dotlambda approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Quiark @dotlambda @bobvanderlinden @worldofpeace @pSub @GrahamcOfBorg